Menu
▾
▴
[ oprofile-Bugs-2878705 ] opcontrol breaks on busybox ash in is_tool_available()
|
From: SourceForge.net <no...@so...> - 2011-05-18 02:41:41
|
Bugs item #2878705, was opened at 2009-10-14 02:10 Message generated for change (Comment added) made by phsung You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=116191&aid=2878705&group_id=16191 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Patrick Sung (phsung) Assigned to: Maynard Johnson (maynardj) Summary: opcontrol breaks on busybox ash in is_tool_available() Initial Comment: I am trying to run oprofile on embedded platform which uses busybox ASH as the default shell. In opcontrol: is_tool_available(), the line that test "which $1 &>/dev/null" always return true and therefor tools are always available even tho it is not. Changing the line from "which $1 &>/dev/null" to "which $1 > /dev/null 2>&1" fixes it. ---------------------------------------------------------------------- >Comment By: Patrick Sung (phsung) Date: 2011-05-17 20:41 Message: I believe William Cohen already created a patch, attached to this bug record. ---------------------------------------------------------------------- Comment By: William Cohen (wcohen) Date: 2011-05-17 10:46 Message: According to http://www.gnu.org/software/bash/manual/bashref.html#Redirections this looks fine. I have tested out a one line patch to address this. ---------------------------------------------------------------------- Comment By: Maynard Johnson (maynardj) Date: 2011-04-20 09:15 Message: Patrick, sorry this bug has languished for so long with no one looking at it. You didn't squeak loud enough, I guess. Is this still a problem? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=116191&aid=2878705&group_id=16191 |