From: Gert W. <gw....@gm...> - 2011-03-09 18:06:13
|
Am Mittwoch, den 09.03.2011, 11:15 -0600 schrieb Maynard Johnson: > On 03/09/2011 11:05 AM, Sheetal Sahasrabudhe wrote: > > Hi Maynard, > > > > On Wed, March 9, 2011 8:26 am, Maynard Johnson wrote: > >> Sheetal, please try the attached patch to fix the enable-gui problem. > >> > >> -Maynard > > > > I applied the patch that you sent and re-ran "make distcheck". > > This time it succeeded. > Gert, sorry I neglected to cc you on the previous posting where I provided the > patch to Sheetal. I've attached again here for convenience. Can you please > review it and give it an ack if you concur with the fix? Thanks. Sorry, I don't think that's the proper way to fix it: Since QT_LIBS is usually an empty string at this point of the platform tests, and "test -n " tests whether the string is not empty, the QT_LIBS variable will not be set and the GUI will not be build. Therefore, the "make diskcheck" succeeds because make just doesn't see that UIC is not properly set. One could argue to use "test -z $QT_LIBS" to avoid overriding an environment variable that may point to the libraries, though. hope that helps, Gert |