Re: [PATCH] Fix some ppc64 event files that had non-UTF8 chars

[Maynard J. <may...@us...>]

William Cohen wrote:
> On 02/25/2011 03:16 PM, Maynard Johnson wrote:
>> A colleague of mine (Daniel Barboza) reported a problem he was seeing when trying to launch the oprofile plugin that's part of the Eclipse Linux Tools project.  He found that the plugin was tripping up on some non-UTF8 characters in the POWER6 events descriptions.  I also found some similar problems in the POWER7 events descriptions.  The patch below fixes those problems.
>>
>> Signed-off-by:  Maynard Johnson <may...@us...>
> 
> Hi Maynard,
> 
> A minor nit, but "processor" is misspelled as "proccessor" in a number of the descriptions.
Thanks for catching.  I'll fix that in a separate patch.
> 
> How were the places that had non-UTF8 characters found? Would it be useful to add a test for non-UTF8 in oprofile-tests/check_style.py to help catch this type of problem?
The original problem was found when trying to run the LTP oprofile plugin, and it was failing with:
	java.lang.ExceptionInInitializerError
        	at java.lang.J9VMInternals.initialize(J9VMInternals.java:218)
	        at org.eclipse.linuxtools.oprofile.core.linux.LinuxOpcontrolProvider.
			setupDaemon(LinuxOpcontrolProvider.java:179)
		blah . . . blah

The person debugging the problem wrote a small Java app that would parse the XML output of 'ophelp --xml', and that program identified the lines with the non-UTF8 characters.

It's a good idea to include a test for non-UTF8 chars, so I'll re-submit the patch with such a test.

Thanks.
-Maynard
> 
> If you have the patch checked into a local git tree, you should also be able to generate the patch file with the the checking info and sign-off with something like:
> 
> git format-patch -s -n HEAD^..
> 
> The advantage with this method is that it would easier to incorporate the patch as-is into the git repo:
> 
> -Will
> 
> 
> ------------------------------------------------------------------------------
> Free Software Download: Index, Search & Analyze Logs and other IT data in 
> Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
> generated by your applications, servers and devices whether physical, virtual
> or in the cloud. Deliver compliance at lower cost and gain new business 
> insights. http://p.sf.net/sfu/splunk-dev2dev 
> _______________________________________________
> oprofile-list mailing list
> opr...@li...
> https://lists.sourceforge.net/lists/listinfo/oprofile-list