Menu
▾
▴
[ oprofile-Bugs-3090939 ] Patch to move from QT3 to QT4[qt3support]
|
From: SourceForge.net <no...@so...> - 2010-11-05 16:38:13
|
Bugs item #3090939, was opened at 2010-10-20 00:24 Message generated for change (Comment added) made by gerddie You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=116191&aid=3090939&group_id=16191 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Gert Wollny (gerddie) Assigned to: Maynard Johnson (maynardj) Summary: Patch to move from QT3 to QT4[qt3support] Initial Comment: It seems that QT3 is outdated and some distributions (like Gentoo) have phased out support for it. With the attached patch the GUI tool is moved to rely on Qt4 by using the qt3 support library. I haven't tested it much, I'm not a Qt expert and there are warnings about not connected signals, although the buttons seem to work like with the QT3 version (i.e. sampling starts stops and the data can be flushed, and the flags selected). ---------------------------------------------------------------------- >Comment By: Gert Wollny (gerddie) Date: 2010-11-05 16:38 Message: When I wrote that I'm not an QT expert I actually meant, that this is my first time I touch QT code. 1. This was to be expected, because the patch removes the test for QT3 and changes to code to use the support includes instead of the old QT3 ones. 2. Could you do a "locate qvariant.h" to see where the file is actually located on this system? 3. configure didn't find moc and/or uic3, so I guess itÄs not in the system path (on Gentoo it is). Luckily I just found out that the pkg-config files define the location and one can read it out easily. Unfortunately uic3 is not in there, hopefully one can assume that's in the same location as moc. ---------------------------------------------------------------------- Comment By: William Cohen (wcohen) Date: 2010-11-05 16:34 Message: I don't know much about qt either. However, I did find information about porting to qt4 at: http://doc.trolltech.com/4.2/porting4.html According to that qt4 is source and binary incompatible with qt3. ---------------------------------------------------------------------- Comment By: Maynard Johnson (maynardj) Date: 2010-11-05 15:20 Message: I have no experience with qt development, so I'm going to post a message to the list asking for community help in reviewing your patch. However, some initial comments from me . . . 1. OProfile currently builds OK with qt3 on my system. But adding this patch and running ./configure as normally, I get the following message: Warning: a working Qt not found or GUI disabled; no GUI will be built 2. On systems where I have qt4 devel packages installed, I can run configure with --enable-qt4 successfully, but then the compilation fails. Unfortunately, the failure is not consistent between distros. On SLES 10 SP1/ppc64, I get the following compile error: ----------- make[3]: Entering directory `/home/mpj/oprof-work/op-qt-update/gui/ui' if g++ -DHAVE_CONFIG_H -I. -I. -I../.. -DQT_SHARED -I/usr/include/Qt3Support -I/usr/include/QtGui -W -Wall -fno-common -ftemplate-depth-50 -Werror -DQT3_SUPPORT -g -O2 -MT oprof_start.base.o -MD -MP -MF ".deps/oprof_start.base.Tpo" -c -o oprof_start.base.o oprof_start.base.cpp; \ then mv -f ".deps/oprof_start.base.Tpo" ".deps/oprof_start.base.Po"; else rm -f ".deps/oprof_start.base.Tpo"; exit 1; fi In file included from oprof_start.base.cpp:1: oprof_start.base.h:4:22: error: qvariant.h: No such file or directory ------------------- On RHEL 6 RC1/ppc64, I get this: ------------------ make[3]: Entering directory `/home/mpj/oprofile/gui/ui' g++ -DHAVE_CONFIG_H -I. -I../.. -DQT_SHARED -DQT3_SUPPORT -I/usr/include/Qt3Support -I/usr/include/QtCore -I/usr/include/QtGui -I/usr/include/QtNetwork -I/usr/include/QtSql -W -Wall -fno-common -ftemplate-depth-50 -Werror -DQT3_SUPPORT -g -O2 -MT oprof_start.base.o -MD -MP -MF .deps/oprof_start.base.Tpo -c -o oprof_start.base.o oprof_start.base.cpp mv -f .deps/oprof_start.base.Tpo .deps/oprof_start.base.Po o oprof_start.base.moc.cpp oprof_start.base.h make[3]: o: Command not found make[3]: [oprof_start.base.moc.cpp] Error 127 (ignored) g++ -DHAVE_CONFIG_H -I. -I../.. -DQT_SHARED -DQT3_SUPPORT -I/usr/include/Qt3Support -I/usr/include/QtCore -I/usr/include/QtGui -I/usr/include/QtNetwork -I/usr/include/QtSql -W -Wall -fno-common -ftemplate-depth-50 -Werror -DQT3_SUPPORT -g -O2 -MT oprof_start.base.moc.o -MD -MP -MF .deps/oprof_start.base.moc.Tpo -c -o oprof_start.base.moc.o oprof_start.base.moc.cpp g++: oprof_start.base.moc.cpp: No such file or directory g++: no input files ----------------------- Can you take a look at these issues and post a new patch that addresses these problems? Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=116191&aid=3090939&group_id=16191 |