Re: [PATCH] reduce sample interval for arch_perf LLC events to get samples

[Maynard J. <may...@us...>]

William Cohen wrote:
> I found the LLC* events used for testing processors that supported the 
> Intel architected events have too large a sample interval. The attached 
> patch reduces the sample interval to something that should get some 
> samples and allow the tests to pass.
> 
> There are probably some other intervals in the tests that are too large.
> 
> Signed-off-by:  William Cohen <wc...@re...>
> 
> 2010-01-20  William Cohen <wc...@re...>
> 
>     * testsuite/lib/op_events.exp: Fix sample interval for LLC* events.
> 
> ? testsuite/testsuite
> Index: testsuite/lib/op_events.exp
> ===================================================================
> RCS file: /cvsroot/oprofile/oprofile-tests/testsuite/lib/op_events.exp,v
> retrieving revision 1.3
> diff -u -r1.3 op_events.exp
> --- testsuite/lib/op_events.exp	18 Jan 2010 18:36:46 -0000	1.3
> +++ testsuite/lib/op_events.exp	20 Jan 2010 18:23:00 -0000
> @@ -164,8 +164,8 @@
>               {1 CPU_CLK_UNHALTED  0 500000}         \
>  	}                                           \
>  	{                                           \
> -             {0 LLC_MISSES        0x41 500000}      \
> -             {1 LLC_REFS          0x4f 500000}      \
> +             {0 LLC_MISSES        0x41 10000}       \
> +             {1 LLC_REFS          0x4f 10000}       \
>  	}                                           \
>  	{                                           \
>               {0 BR_INST_RETIRED   0 500000}         \

Looks reasonable to me.  Go ahead and commit, Will.

Thanks.
-Maynard

> 
> -Will
> 
> 
> ------------------------------------------------------------------------
> 
> ------------------------------------------------------------------------------
> Throughout its 18-year history, RSA Conference consistently attracts the
> world's best and brightest in the field, creating opportunities for Conference
> attendees to learn about information security's most important issues through
> interactions with peers, luminaries and emerging and established companies.
> http://p.sf.net/sfu/rsaconf-dev2dev
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> oprofile-list mailing list
> opr...@li...
> https://lists.sourceforge.net/lists/listinfo/oprofile-list