Re: [PATCH 04/10] opcontrol: fix deinit, kill daemon only if running

[Maynard J. <may...@us...>]

John Levon wrote:
> On Fri, Sep 04, 2009 at 02:21:46PM -0500, Maynard Johnson wrote:
> 
>> Robert Richter wrote:
>>> When using option --deinit the functions do_stop() and do_kill_daemon()
>>> are only called, if the daemon is running. This prevents the
>>> irritating message 'Daemon not running' for an init/deinit sequence.
>> I'm inclined to accept this patch, but I first wanted to at least give the opportunity for others in the community to express an opinion, since the patch results in a small change in user interaction.  While the "Daemon not running" message when doing deinit might be annoying to some when they *know* it's not running (because they previously did a shutdown), others might like or even need that feedback.  For instance, in the case where you just want to make sure oprofile isn't running and using system resources, so you run 'opcontrol --deinit'.  The "Daemon not running" message tells you immediately that oprofile was not active.
> 
> I'm on Robert's side on this one.

Patch committed.

Thanks.
-Maynard
> 
> regards
> john