[ oprofile-Bugs-2040417 ] 0.9.4: execvp call for opjitconv does not work

[SourceForge.net <no...@so...>]

Bugs item #2040417, was opened at 2008-08-06 16:10
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=116191&aid=2040417&group_id=16191

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: 0.9.4: execvp call for opjitconv does not work

Initial Comment:
Hi,
I was doing an opagent implementation for the cacao jvm and as such installed oprofile 0.9.4 into my home (--prefix=/home/rschus/INSTALL/oprofile).

I found these error messages in the oprofiled.log:
Failed to exec /home/rschus/INSTALL/oprofile/bin//opjitconv: No such file or directory
JIT dump processing exited abnormally: 1

This made samples taken in JIT compiled code not show up in the summaries.

By looking at daemon/init.c I found out that you should provide opjitconv_path as the first argument to the execvp() function instead of "opjitconv" (which should go into the first place in the argument array then).

With that change the error messages in the log disappeared and instead the samples taken in the JIT compiled code showed up in the summaries. Yay!

Attached is patch is used.

If you need this signed of line:

Signed-off-by: Robert Schuster <rob...@fs...>

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2008-08-08 09:50

Message:
Logged In: NO 

Hi Daniel,
you will only experience the bug if you install oprofile to a directory
that is not in your $PATH because then looking up "opjitconv" will fail.

Thanks for applying the patch. I think this can be closed now.

Regards
Robert

----------------------------------------------------------------------

Comment By: hanseld (hanseld)
Date: 2008-08-08 08:48

Message:
Logged In: YES 
user_id=1958718
Originator: NO

Hi Robert!

I've taken a look into that problem.
On my tests there were no issues according this implementation part.
But after reading the description of execvp() function I've seen that
the current implementation does not follow the description.

Because of that your patch is accepted and will be integrated
as soon as possible.

Thank you.

Kind regards,
Daniel Hansel

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=116191&aid=2040417&group_id=16191