Re: [patch 2/7] Oprofile AMD IBS support

[Jason Y. <jas...@am...>]

Maynard Johnson wrote:
> Jason Yeh wrote:
>> This patch contains daemon/kernel module interface change and daemon code processing \
>> IBS events.
>>   
> Sorry to say, but this patch has many style issues.  Please see the
> "Contribute" page on the OProfile website for info on style.  The
> check_style.py python script found many problems, including lines too
> long, camelCase naming, trailing comments, and spaces used for
> indentation.  The "spaces used for indentation" was kind of strange . .
> . your new functions in opd_trans.c all seem to have a space before
> every tab indent.  Also, please don't make irrelevant changes with your
> patches (e.g., style changes, extra or removed line breaks, etc.).  And
> one final style issue . . . your comment style is inconsistent.  For C
> source, please use the C89 style ("/* ... */"); for C++ source, the C99
> style ("// ...") is fine.
> 
> I really think the changes you're making to opd_trans.c should, as much
> as possible, be factored out into a separate opd_ibs.c file. See
> opd_spu.c as an example of arch-specific daemon processing.  I'll defer
> further comments for your next version.
> 

Points taking. I will make the changes to split the code to opd_ibs.c and
be sure to run check_styple.ph before sending out the patch next time.

Jason