Re: [Oprofile, RFC/PATCH] --root option

[Philippe E. <ph...@wa...>]

On Thu, 08 Nov 2007 at 20:24 +0000, John Levon wrote:

> On Thu, Nov 08, 2007 at 08:15:50PM +0100, Philippe Elie wrote:


> > RCS file: /cvsroot/oprofile/oprofile/doc/opreport.1.in,v
> > retrieving revision 1.15
> > diff -u -p -r1.15 opreport.1.in
> > --- doc/opreport.1.in	24 Nov 2006 03:39:27 -0000	1.15
> > +++ doc/opreport.1.in	8 Nov 2007 18:40:36 -0000
> > @@ -61,6 +61,10 @@ Comma-separated list of additional paths
> >  This is needed to find modules in kernels 2.6 and upwards.
> >  .br
> >  .TP
> > +.BI "--root / -R [path]"
> > +A path to a filesystem to search for additional binaries.
> > +.br
> > +.TP
> >  .BI "--include-symbols / -i [symbols]"
> >  Only include symbols in the given comma-separated list.
> >  .br
> > Index: doc/oprofile.xml
> > ===================================================================
> > RCS file: /cvsroot/oprofile/oprofile/doc/oprofile.xml,v
> > retrieving revision 1.165
> > diff -u -p -r1.165 oprofile.xml
> > --- doc/oprofile.xml	17 Oct 2007 17:18:58 -0000	1.165
> > +++ doc/oprofile.xml	8 Nov 2007 18:40:40 -0000
> > @@ -1762,6 +1762,9 @@ Show help message.
> >  Comma-separated list of additional paths to search for binaries.
> >  This is needed to find modules in kernels 2.6 and upwards.
> >  </para></listitem></varlistentry>
> > +<varlistentry><term><option>--root-path / -R [path]</option></term><listitem><para>
> 
> --root-path or --root? I'd prefer the latter, but currently it's
> inconsistent

Ok for --root, anyway the doc is a bit misleading, it's not a path to
search for missing binaries but a replacement of the / fs and if an
archive:path is given an alternative path for a missing binary, there
is no notion of search ala --image-path. Help to reword the doc is
welcome.

-- 
Phe