From: John L. <le...@mo...> - 2007-11-08 20:24:28
|
On Thu, Nov 08, 2007 at 08:15:50PM +0100, Philippe Elie wrote: > It was discussed the need of a --root option, Richard Purdie provided a > first implementation which was never applied, then I went with multiple > change making this patch impossible to apply, I cooked up a new one, quite > different, a few documentation chunk, come from Richard patch. > > My implementation works as follow, if a --root option is given the / fs is > not used to retrieve binaries, if an archive:path is given a binary found > in the archive get precedence over one found in the root path, samples > files are never retrieved through the root path but through the archive > path if any. Unlike the previous patch I do not merge archive path and > root path in a vector<string> paths; They have disctinct meaning afaics > and I prefer to keep them separate. > > Most meaningfull change are done locate_images.cpp, most complication come > from locating kernel module. > > Index: doc/opannotate.1.in > =================================================================== > RCS file: /cvsroot/oprofile/oprofile/doc/opannotate.1.in,v > retrieving revision 1.13 > diff -u -p -r1.13 opannotate.1.in > --- doc/opannotate.1.in 24 Nov 2006 03:39:27 -0000 1.13 > +++ doc/opannotate.1.in 8 Nov 2007 18:40:36 -0000 > @@ -50,6 +50,10 @@ Comma-separated list of additional paths > This is needed to find modules in kernels 2.6 and upwards. > .br > .TP > +.BI "--root / -R [path]" > +A path to a filesystem to search for additional binaries. > +.br > +.TP > .BI "--include-file [files]" > Only include files in the given comma-separated list of glob patterns. > .br > Index: doc/oparchive.1.in > =================================================================== > RCS file: /cvsroot/oprofile/oprofile/doc/oparchive.1.in,v > retrieving revision 1.6 > diff -u -p -r1.6 oparchive.1.in > --- doc/oparchive.1.in 20 May 2007 17:31:39 -0000 1.6 > +++ doc/oparchive.1.in 8 Nov 2007 18:40:36 -0000 > @@ -42,6 +42,10 @@ Comma-separated list of additional paths > This is needed to find modules in kernels 2.6 and upwards. > .br > .TP > +.BI "--root / -R [path]" > +A path to a filesystem to search for additional binaries. > +.br > +.TP > .BI "--output-directory / -o [directory]" > Output to the given directory. There is no default. This must be specified. > .br > Index: doc/opgprof.1.in > =================================================================== > RCS file: /cvsroot/oprofile/oprofile/doc/opgprof.1.in,v > retrieving revision 1.7 > diff -u -p -r1.7 opgprof.1.in > --- doc/opgprof.1.in 24 Nov 2006 03:39:27 -0000 1.7 > +++ doc/opgprof.1.in 8 Nov 2007 18:40:36 -0000 > @@ -38,6 +38,10 @@ Comma-separated list of additional paths > This is needed to find modules in kernels 2.6 and upwards. > .br > .TP > +.BI "--root / -R [path]" > +A path to a filesystem to search for additional binaries. > +.br > +.TP > .BI "--threshold / -t [percentage]" > Only output data for symbols that have more than the given percentage > of total samples. > Index: doc/opreport.1.in > =================================================================== > RCS file: /cvsroot/oprofile/oprofile/doc/opreport.1.in,v > retrieving revision 1.15 > diff -u -p -r1.15 opreport.1.in > --- doc/opreport.1.in 24 Nov 2006 03:39:27 -0000 1.15 > +++ doc/opreport.1.in 8 Nov 2007 18:40:36 -0000 > @@ -61,6 +61,10 @@ Comma-separated list of additional paths > This is needed to find modules in kernels 2.6 and upwards. > .br > .TP > +.BI "--root / -R [path]" > +A path to a filesystem to search for additional binaries. > +.br > +.TP > .BI "--include-symbols / -i [symbols]" > Only include symbols in the given comma-separated list. > .br > Index: doc/oprofile.xml > =================================================================== > RCS file: /cvsroot/oprofile/oprofile/doc/oprofile.xml,v > retrieving revision 1.165 > diff -u -p -r1.165 oprofile.xml > --- doc/oprofile.xml 17 Oct 2007 17:18:58 -0000 1.165 > +++ doc/oprofile.xml 8 Nov 2007 18:40:40 -0000 > @@ -1762,6 +1762,9 @@ Show help message. > Comma-separated list of additional paths to search for binaries. > This is needed to find modules in kernels 2.6 and upwards. > </para></listitem></varlistentry> > +<varlistentry><term><option>--root-path / -R [path]</option></term><listitem><para> --root-path or --root? I'd prefer the latter, but currently it's inconsistent regards john |