Menu
▾
▴
[patch 5/9][RFC] Oprofile JIT support - Remove unnecessary offset calculation.
|
From: Jens W. <jen...@de...> - 2007-07-17 16:43:59
|
The statement abfd.sym_offset(i, start) is always 0 here. symb_entry.sample.vma has to be exaclty the vma as it comes from the binary, this is expected e.g. in opannotate/find_symbol To go sure I checked this with a debug assertion and tested with opreport / opannotate. --- libpp/profile_container.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: oprofile-0.9.2-jit/libpp/profile_container.cpp =================================================================== --- oprofile-0.9.2-jit.orig/libpp/profile_container.cpp +++ oprofile-0.9.2-jit/libpp/profile_container.cpp @@ -108,9 +108,8 @@ symb_entry.image_name = image_names.create(image_name); symb_entry.app_name = image_names.create(app_name); - bfd_vma base_vma = abfd.syms[i].vma(); - symb_entry.sample.vma = abfd.sym_offset(i, start) + base_vma; + symb_entry.sample.vma = abfd.syms[i].vma(); symbol_entry const * symbol = symbols->insert(symb_entry); -- Jens Wilke Linux on System z - Application Development Tools phone +49-(0)7031-16-3936 - tl *120-3936 - email jen...@de... IBM Germany Lab, Schoenaicher Str. 220, 71032 Boeblingen |