Re: [Cbe-oss-dev] [RFC, PATCH] CELL Oprofile SPU profiling updated patch

[Arnd B. <ar...@ar...>]

On Friday 16 February 2007 01:32, Maynard Johnson wrote:
> config OPROFILE_CELL
> =A0 =A0 =A0 =A0 bool "OProfile for Cell Broadband Engine"
> =A0 =A0 =A0 =A0 depends on OPROFILE && SPU_FS
> =A0 =A0 =A0 =A0 default y if ((SPU_FS =3D y && OPROFILE =3D y) || (SPU_FS=
 =3D m &&=20
> OPROFILE =3D m))
> =A0 =A0 =A0 =A0 help
> =A0 =A0 =A0 =A0 =A0 Profiling of Cell BE SPUs requires special support en=
abled
> =A0 =A0 =A0 =A0 =A0 by this option. =A0Both SPU_FS and OPROFILE options m=
ust be
> =A0 =A0 =A0 =A0 =A0 set 'y' or both be set 'm'.
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>=20
> Can anyone see a problem with any of this . . . or perhaps a suggestion=20
> of a better way?

The text suggests it doesn't allow SPU_FS=3Dy with OPROFILE=3Dm, which I th=
ink
should be allowed. I also don't see any place in the code where you actually
use CONFIG_OPROFILE_CELL.

Ideally, you should be able to have an oprofile_spu module that can be
loaded after spufs.ko and oprofile.ko. In that case you only need

config OPROFILE_SPU
	depends on OPROFILE && SPU_FS
	default y

and it will automatically build oprofile_spu as a module if one of the two
is a module and won't build it if one of them is disabled.

	Arnd <><