From: Andrew M. <ak...@os...> - 2006-11-17 10:14:15
|
On Fri, 17 Nov 2006 10:59:07 +0100 Mikael Pettersson <mi...@it...> wrote: > Andrew Morton writes: > > On Thu, 16 Nov 2006 11:55:46 +0100 > > Mikael Pettersson <mi...@it...> wrote: > > > > > Andrew Morton writes: > > > > Surely the appropriate behaviour is to allow oprofile to steal the NMI and > > > > to then put the NMI back to doing the watchdog thing after oprofile has > > > > finished with it. > > > > > > Which is _exactly_ what pre-2.6.19-rc1 kernels did. I implemented > > > the in-kernel API allowing real performance counter drivers like > > > oprofile (and perfctr) to claim the HW from the NMI watchdog, > > > do their work, and then release it which resumed the watchdog. > > > > OK. But from Andi's comments it seems that the NMI watchdog was failing to > > resume its operation. > > It certainly worked when I originally implemented it. If it didn't work > that way before 2.6.19-rc1 butchered it then that would have been a bug > that should have been fixed. Oh. OK. Meanwhile, 2.6.19-rc6 remains unfixed. |