From: John L. <mov...@us...> - 2004-01-19 20:00:58
|
Update of /cvsroot/oprofile/oprofile/daemon/liblegacy In directory sc8-pr-cvs1:/tmp/cvs-serv5113/daemon/liblegacy Modified Files: init.c opd_image.c opd_proc.c Log Message: check_style pedantry, no changelog. Index: init.c =================================================================== RCS file: /cvsroot/oprofile/oprofile/daemon/liblegacy/init.c,v retrieving revision 1.6 retrieving revision 1.7 diff -u -p -d -r1.6 -r1.7 --- init.c 18 Jan 2004 02:21:13 -0000 1.6 +++ init.c 19 Jan 2004 20:00:23 -0000 1.7 @@ -340,7 +340,7 @@ static void opd_24_init(void) s_buf_bytesize = sizeof(struct op_buffer_head) + opd_buf_size * sizeof(struct op_sample); - sbuf = xmalloc(s_buf_bytesize); + sbuf = xmalloc(s_buf_bytesize); n_buf_bytesize = opd_note_buf_size * sizeof(struct op_note); nbuf = xmalloc(n_buf_bytesize); Index: opd_image.c =================================================================== RCS file: /cvsroot/oprofile/oprofile/daemon/liblegacy/opd_image.c,v retrieving revision 1.7 retrieving revision 1.8 diff -u -p -d -r1.7 -r1.8 --- opd_image.c 3 Nov 2003 23:48:45 -0000 1.7 +++ opd_image.c 19 Jan 2004 20:00:23 -0000 1.8 @@ -221,7 +221,8 @@ static int is_same_image(struct opd_imag static struct opd_image * opd_find_image(char const * name, char const * app_name, pid_t tid, pid_t tgid) { - struct opd_image * image = 0; /* supress warn non initialized use */ + /* suppress uninitialized use warning */ + struct opd_image * image = 0; struct list_head * pos; size_t bucket; Index: opd_proc.c =================================================================== RCS file: /cvsroot/oprofile/oprofile/daemon/liblegacy/opd_proc.c,v retrieving revision 1.8 retrieving revision 1.9 diff -u -p -d -r1.8 -r1.9 --- opd_proc.c 18 Jan 2004 02:21:13 -0000 1.8 +++ opd_proc.c 19 Jan 2004 20:00:23 -0000 1.9 @@ -282,9 +282,8 @@ void opd_handle_fork(struct op_note cons * image e.g. pid re-use, multiple mapping with the * same mapping name etc. */ struct opd_image * image = - opd_get_image(map->image->name, old->name, - map->image->kernel, note->addr, - note->len); + opd_get_image(map->image->name, old->name, + map->image->kernel, note->addr, note->len); opd_add_mapping(proc, image, map->start, map->offset, map->end); } @@ -300,10 +299,10 @@ void opd_handle_exec(pid_t tid, pid_t tg /* There is a race for samples received between fork/exec sequence. * These samples belong to the old mapping but we can not say if - * samples has been received before the exec or after. This explain + * samples has been received before the exec or after. This explains * the message "Couldn't find map for ..." in verbose mode. * - * Unhopefully it is difficult to get an estimation of these misplaced + * Unhappily, it is difficult to get an estimation of these misplaced * samples, the error message can count only out of mapping samples but * not samples between the race and inside the mapping of the exec'ed * process :/. |