Re: [Openvpn-devel] [PATCH] Fix incorrect use of get_ipv6_addr() for iroute options.

[Steffan K. <st...@ka...>]

On 08-03-15 13:56, Gert Doering wrote:
> get_ipv6_addr() returns "bool/false", not "int < 0" to signal error.
>
> Signed-off-by: Gert Doering <ge...@gr...>
> ---
>   src/openvpn/options.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/openvpn/options.c b/src/openvpn/options.c
> index 20b37db..df9a641 100644
> --- a/src/openvpn/options.c
> +++ b/src/openvpn/options.c
> @@ -1254,7 +1254,7 @@ option_iroute_ipv6 (struct options *o,
>
>     ALLOC_OBJ_GC (ir, struct iroute_ipv6, &o->gc);
>
> -  if ( get_ipv6_addr (prefix_str, &ir->network, &ir->netbits, NULL, msglevel ) < 0 )
> +  if ( !get_ipv6_addr (prefix_str, &ir->network, &ir->netbits, NULL, msglevel ))
>       {
>         msg (msglevel, "in --iroute-ipv6 %s: Bad IPv6 prefix specification",
>   	   prefix_str);

ACK

-Steffan