#480 1.7.2 - Default User-Agent instead of configured in CANCEL

[Anonymous]

In a CANCEL request OpenSIPS 1.7.2 sends the default user-agent instead of the user-agent configured in the configuration file.

I think these changes in "modules/tm/t_msgbuilder.c" fix the problem but i'm not sure if this is a complete fix and if it doesn't break anything else:

933c933
< *len += user_agent_header.len + CRLF_LEN;
---
> *len += USER_AGENT_LEN + CRLF_LEN;
978,979c978
< append_string(p, user_agent_header.s, user_agent_header.len);
< append_string(p, CRLF, CRLF_LEN);
---
> append_string(p,USER_AGENT CRLF, USER_AGENT_LEN+CRLF_LEN );

Can someone look into this?
Thanks!

[a719719]

I have the same problem but i don't think this patch solves the real cause.

This ua problem is related to this bug: http://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3316230&group_id=232389

When i use append_hf in the local_route the ACK that OS sends after that is all mangled.
Also in CANCEL request the ua is default.

[a719719]

I have updated https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3316230&group_id=232389 with a configuration file and traces of this problem in version 1.7.2.

I guess this bug report is a duplicate then.

[Bogdan-Andrei Iancu]

Hi,

Thank you for the fix - it is more the perfect :). I just uploaded it on SVN and backported to the stable releases.

Next time, please put a name on it, so that we can give you credit for the work ;).

Regards,
Bogdan