#480 1.7.2 - Default User-Agent instead of configured in CANCEL

1.7.x
closed-fixed
modules (454)
5
2012-03-05
2012-02-24
Anonymous
No

In a CANCEL request OpenSIPS 1.7.2 sends the default user-agent instead of the user-agent configured in the configuration file.

I think these changes in "modules/tm/t_msgbuilder.c" fix the problem but i'm not sure if this is a complete fix and if it doesn't break anything else:

933c933
< *len += user_agent_header.len + CRLF_LEN;
---
> *len += USER_AGENT_LEN + CRLF_LEN;
978,979c978
< append_string(p, user_agent_header.s, user_agent_header.len);
< append_string(p, CRLF, CRLF_LEN);
---
> append_string(p,USER_AGENT CRLF, USER_AGENT_LEN+CRLF_LEN );

Can someone look into this?
Thanks!

Discussion

  • Bogdan-Andrei Iancu

    • assigned_to: nobody --> bogdan_iancu
    • status: open --> closed-fixed
     
  • Bogdan-Andrei Iancu

    Hi,

    Thank you for the fix - it is more the perfect :). I just uploaded it on SVN and backported to the stable releases.

    Next time, please put a name on it, so that we can give you credit for the work ;).

    Regards,
    Bogdan

     

Log in to post a comment.