Re: [Opensg-core] [Opensg-commits] r1380 - in trunk/Source: Base/Base System/Cluster/Base System/FieldContainer/Base

[Gerrit V. <vo...@ca...>]

Hi,

On Mon, 2008-07-21 at 13:28 -0500, Carsten Neumann wrote:
> 	Hi,
> 
> > Log:
> > fixed: refcount funtion naming
> >      : allow memory objects to use the ref/transit ptr
> 
> thanks for looking into this. However, ATM something like this
> 
> typedef RefCountPtr<GraphOp, UnrecordedRefCountPolicy> GraphOpRefPtr;
> 
> is unusable as the ref count policies still expect to operate on 
> FieldContainer *.
> I'm happy to work on a solution, but wanted to get feedback on which way 
> to go:
> 
> - move OSGRefCountPolicies.h to Base as well, make them work on 
> MemoryObject and derive ReflexiveContainer from MemoryObject.
> 
> OR
> 
> - like above, but don't derive RC from MO, just add a second set of 
> functions to the policies that take MO arguments.
> 
> OR
> 
> - add a separate set of MemoryObjectRefCountPolicies (?) and use those 
> in typedefs like the above.

I used a separate MemObjRefCountPolicy structure (at the end of
OSGMemoryObject.h). The only thing I did not look into was having
weak ref count ptrs for memory objects (I did not need those).

Usage than is like :

typedef RefCountPtr<OFRecord, MemObjRefCountPolicy> OFRecordRCPtr;


I don't see the need to mix memobjects and containers so I'm fine with
separate policies.


kind regards,
  gerrit