Re: [openobex-users] [PATCH] obexftp over bluetooth, multiple hci devices.

[Manuel N. <nar...@gm...>]

Hi Christian,
> your hci selection option is a nice addition to ObexFTP, thanks. 
No problem.
> Not every OpenOBEX feature is implemented in ObexFTP right now, but it would
> be nice to get there someday.
>   
Cool.

> - Is the hci-id really something we need in the client struct? Isn't it
> something like device and channel?
>   I'm thinking of discovery here, would the user perhaps want to
> discover from all devices, then select hci-id along with device and channel?
>   
It's like this, suppose you have 2 or 3 bluetooth dongle (for example 
USB) connected to your PC. Then the devices hci0 hci1 and hci2 will be 
available. By default hciID will be -1 and will be passed to openobex as 
NULL so then openobex will ask BlueZ to choose from any hci device 
available at it own will. I had added it to the client struct, because I 
didn't want change any function call declaration, as I was not sure it 
was going to break something.
> - I'm open to changes in coding style (the bt_discovery.c is mostly
> copied example code in GNU style, other code is mostly K&R style).
> Please submit seperate patches though.
>   
You sure it was in GNU style? It wasn't idented at all.
> - Please don't remove '(void)' from functions it's nice to have those
> with lint.
>   
Sorry, I deleted it, and then forgot to add it back.
> - If possible please diff against the current svn/cvs (see the wiki/trac).
>   
No problem, I can make the patch again if you want. I couldn't find the 
url of the svn yesterday. Can you please give it to me?

> - And then perhaps submit patches to the bug tracker there.
>   
Ok you want me to create a bug report and then submit the patch there? 
No problem

Thanks,
Manuel