From: Hendrik S. <po...@he...> - 2009-05-27 08:15:15
|
Hi Marcel, Zitat von Marcel Holtmann <ma...@ho...>: >> > > so I think it is time to release openobex-1.6 during some time next >> > > week. What are the pending patches? >> > >> > You can pull the "updates" branch from >> > git://gitorious.org/openobex/mainline.git >> > >> > When Alex patches are applied, I need an additional round to further adapt >> > to it. The patches are already there, just not uploaded, yet. >> >> If you pull from "usb" branch instead, you also get Alex' patches. >> I already changes version and SONAME but with CMake, I do not follow the >> libtool naming scheme, thus using .so.1.6.0 instead of .so.2.0.0. >> This has no >> practical implications, as both have the .so.2 link. > > as I said, I decided to 2.0.0 and also pushed that change out now. Yes, I know. I also acknoledge that this is a work-around for libtool that I do not follow in the CMakeLists.txt files. Unless you say that the release version is not openobex-1.6 but openobex-2.0. Is that the case? > I also started fixing out screwed up declarations overload. Hope that > works now as expected. Let me test those changes for the Win32 build before release, please! It might needs other changes. I will tell you when I'm done with this. > It fixes all built warnings except these two: > > /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. > -I.. -I../include -fvisibility=hidden -Wall -O2 > -D_FORTIFY_SOURCE=2 -Werror -Wextra -Wno-unused-parameter > -Wno-missing-field-initializers -Wdeclaration-after-statement > -Wmissing-declarations -Wredundant-decls -Wcast-align > -D_FORTIFY_SOURCE=2 -MT libopenobex_la-obex.lo -MD -MP -MF > .deps/libopenobex_la-obex.Tpo -c -o libopenobex_la-obex.lo `test -f > 'obex.c' || echo './'`obex.c > gcc -DHAVE_CONFIG_H -I. -I.. -I../include -fvisibility=hidden -Wall > -O2 -D_FORTIFY_SOURCE=2 -Werror -Wextra -Wno-unused-parameter > -Wno-missing-field-initializers -Wdeclaration-after-statement > -Wmissing-declarations -Wredundant-decls -Wcast-align > -D_FORTIFY_SOURCE=2 -MT libopenobex_la-obex.lo -MD -MP -MF > .deps/libopenobex_la-obex.Tpo -c obex.c -fPIC -DPIC -o > .libs/libopenobex_la-obex.o > cc1: warnings being treated as errors > obex.c:1180: error: no previous declaration for ‘BtOBEX_ServerRegister’ > obex.c:1207: error: no previous declaration for ‘BtOBEX_TransportConnect’ > > So how do we get rid of these two? I wanna build it with -Werror now. in lib/obex.c: #include "bluez_compat.h" before #include <openobex/obex.h> Additionally, you _MUST_ make sure that include/ is searched by the preprocessor before /usr/include. Else you might get strange build problems when openobex is already installed. HS |