Re: [Openhpi-devel] Patch for enhancement #2984110 for review

[Bishop, M. (I. Linux/Telco) <mic...@hp...>]

Bryan -

I will correct this.  Thanks for your feedback!

--michael


> -----Original Message-----
> From: Sutula, Bryan (Open Source Program Office)
> Sent: Friday, April 16, 2010 11:10 PM
> To: ope...@li...
> Subject: Re: [Openhpi-devel] Patch for enhancement #2984110 for review
>
>
> On Fri, 2010-04-16 at 20:30 +0000, Bishop, Michael (ISB Linux/Telco)
> wrote:
>
> > Comments are welcome.
>
> Well...you asked...
>
> In the past, the project has tried to pay attention to code format.
> (Ref http://openhpi.org/Developers, Coding Style at the
> bottom)  Though
> it's not spelled out explicitly, the format implies trying to keep the
> source code such that it can be maintained in 80-column terminal
> windows.  My personal preference is to stick to this style,
> rather than
> allowing lines to become so long as to require unusual-sized editing
> windows.  Doing so allows me to keep a number of open terminal windows
> on my screen, and I lose this if my windows have to be wider.
>  It's also
> frustrating to have to re-size windows all the time just because the
> last person to edit a particular file used a different width editor.
> Therefore, I'd recommend reformatting the longer lines of
> this patch to
> be <= 80 characters per line.
>
> I recognize that not all of the project code has held to this
> guideline.
> Also, if others feel that this is an outmoded suggestion, please speak
> up.  We don't have to stick with ideas that have outlived their
> usefulness.
>
> Bryan
>
>
> --------------------------------------------------------------
> ----------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Openhpi-devel mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/openhpi-devel
>