[oh-tracker] [ openhpi-Bugs-1804512 ] Debug output occurring during normal operation

[SourceForge.net <no...@so...>]

Bugs item #1804512, was opened at 2007-09-28 15:03
Message generated for change (Comment added) made by sutula
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=1804512&group_id=71730

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: OpenHPI base library
Group: 2.11.0
>Status: Open
>Resolution: None
Priority: 3
Private: No
Submitted By: Bryan Sutula (sutula)
Assigned to: Bryan Sutula (sutula)
Summary: Debug output occurring during normal operation

Initial Comment:
Even during normal operation, some debug logging/output occurs.  A specific example is:

  ipmi.cpp, 2265, ipmidirect discover_resources

The cause is that there are two current macros in the code, dbg() and trace().  Though dbg() is usually used for errors and trace() for debug stuff, dbg() is sometimes used for non-errors.

The names are unfortunate, in this case.  In order to fix this, we suggest:

1) Rename dbg() to be err() everywhere in the code.  Then, rename trace() to be dbg() everywhere in the code.

2) As they are found, change err() calls to be dbg() to eliminate extra output during normal operation.

This bug report is the placeholder for #2 above.  I would suggest leaving this open until we have had time to go through all the code and look over dbg() and err() usage.

See issue tracker #1804510 for item #1 above.

----------------------------------------------------------------------

>Comment By: Bryan Sutula (sutula)
Date: 2007-11-29 11:15

Message:
Logged In: YES 
user_id=814412
Originator: YES

The specific line was an example.  My current status:

- Reviewed all plugin code, made a number of changes

  - There was some funny stuff found in the OpenIPMI plugin...I have notes
and need to follow up with the authors, but this could be a separate
tracker issue

- Have not reviewed the infrastructure code.  Will try to do this today,
then will close this out.

----------------------------------------------------------------------

Comment By: Bryan Sutula (sutula)
Date: 2007-11-29 11:15

Message:
Logged In: YES 
user_id=814412
Originator: YES

Finished changes as of trunk revision 6609.

----------------------------------------------------------------------

Comment By: Bryan Sutula (sutula)
Date: 2007-11-29 09:15

Message:
Logged In: YES 
user_id=814412
Originator: YES

The specific line was an example.  My current status:

- Reviewed all plugin code, made a number of changes

  - There was some funny stuff found in the OpenIPMI plugin...I have notes
and need to follow up with the authors, but this could be a separate
tracker issue

- Have not reviewed the infrastructure code.  Will try to do this today,
then will close this out.

----------------------------------------------------------------------

Comment By: Renier Morales (renierm)
Date: 2007-11-28 17:59

Message:
Logged In: YES 
user_id=660960
Originator: NO

This refers to a specific line in ipmi.cpp which looks fine to me. Can
this be closed?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=1804512&group_id=71730