Re: [Openh323gk-developer] Re: Password ?

[Chih-Wei H. <cw...@li...>]

h3...@ke... :
> 
> I can not see any disagreement because there is no any responce to my
> patches....
>

Are two days *too long* for you to wait?

I'm usually busy and I often don't work (or even read email)
on weekends.

If I didn't give response to your patch in time, that probably means
1. I am too busy to read that patch yet.
2. There are some issues about it that I still concern about.
3. Simply I forgot it :p (but it isn't for this case).


Indeed it's unfair to say I didn't give any response to your patches.
One of your patch has already be accepted and committed.
(in fact I extend it to a more general feature)

For the other one, I have said to you that it may not be accepted
because it changes the format of CDR.
Simply saying it's very important to you is not a convincible way.
One always requests a feature that he/she considers very important to he/she.
Yes, you make it optional so it won't break the compatibility.
But it makes the codes a little ugly.
What if others send similar patches to me and say:
"hey, I add a field XXX to CDR since it's very important to us.
To maintain the compatibility I also make it optional."
If everybody sends me such a patch, what should I do?
If I accept your patch, how can I reject others?
The source codes are getting more and more ugly
if I accept all these patches... :(

Besides the compatibility issue, your patch is still buggy.
It doesn't work for calls between (to or from) zones.

Anyway, I'm still trying to solve this, but I won't promise anything.
I may simply reject you if there is no better solution.

Even if you are rejected, don't be disappointed.
You can still hold your patches locally and update
from CVS for other bugs fixed and features enhanced.
In this way you can still follow the progress of the project
without lost your local modifications.
That what CVS supposes to do.


-- 
    ~     Chih-Wei Huang (cw...@li...)
   'v'    CLDP Project : http://www.linux.org.tw/CLDP/ (Coordinator)
  // \\   CLE  Project : http://cle.linux.org.tw/CLE/  (Developer)
/(   )\  I18N Project : http://i18n.linux.org.tw/     (Translator)
  ^`~'^   HomePage     : http://www.cwhuang.idv.tw/