Re: [Openh323gk-developer] Bug Fix

[Zygmuntowicz M. <m.z...@on...>]

A very good point! Thank you - it's fixed in the cvs.

----- Original Message ----- 
From: "Stelios V. Vaiopoulos" <ste...@na...>
Sent: Thursday, February 05, 2004 1:39 PM


Under certain circumastances (for example when calls come from CallManager) GNUGK 2.0.7 crashes on the Call Setup.
Guess this is due to a bug in the CallRec::CallRec(const Q931& q931pdu,....) constructor and specificaly in the following code
fragment:
.....
 if( setup.HasOptionalField(H225_Setup_UUIE::e_sourceCallSignalAddress) )
  m_srcSignalAddr =
   (H225_TransportAddress*)(setup.m_sourceCallSignalAddress.Clone());
 else if( m_callingSocket ) {
  m_srcSignalAddr = new H225_TransportAddress(H225_TransportAddress::e_ipAddress);   << HERE IS THE ROOT OF THE PROBLEM

  PIPSocket::Address addr;
  WORD port = 0;
  m_callingSocket->GetPeerAddress(addr,port);
.....

Seems that the H225_TransportAddress constructor doesn't set the tag, so to solve the problem add the following line just after the
construction:

m_srcSignalAddr->SetTag(H225_TransportAddress::e_ipAddress);


Regards,
Stelios Vaiopoulos