Re: [Openh323gk-developer] ProxyChannel.cxx: ScreenCallingPartyNumberIE and UUIE

[Alex G. <ale...@ma...>]

Hi all.

Please correct me if I'm not right.

There is info someone doesn't want to show to the terminating party.
Calling party number may be included in:
1) CallingPartyNumber IE of Q.931
2) User-User IE of Q.931
3) dialedDigits entry of sourceAddress of Setup PDU

So isn't it better to modify all of these fields if required? So the gk 
config option would be:

ScreenCallingPartyNumber=123456

Another problem: someone doesn't want to show H323ID of calling party to 
the terminationg party. This information, as I see, may be included in 
h323_ID entry of sourceAddress. I add little patch to modify this field:
---

diff -u -5 -r1.39.2.110 ProxyChannel.cxx
--- ProxyChannel.cxx	11 Dec 2003 00:00:31 -0000	1.39.2.110
+++ ProxyChannel.cxx	29 Jan 2004 13:35:58 -0000
@@ -1156,10 +1156,19 @@
 			Setup.IncludeOptionalField(H225_Setup_UUIE::e_sourceAddress);
 		Setup.m_sourceAddress.SetSize(s+1);
 		H323SetAliasAddress(H323ID, Setup.m_sourceAddress[s], 
H225_AliasAddress::e_h323_ID);
 	}
 +	// modify h323_ID of sourceAddress field if required
+	if (Setup.HasOptionalField(H225_Setup_UUIE::e_sourceAddress)) {
+		PString alias = GkConfig()->GetString(RoutedSec, 
"ScreenSourceAddressH323ID", "");
+		if (!alias)
+			for (PINDEX n = 0; n < Setup.m_sourceAddress.GetSize(); ++n)
+				if (Setup.m_sourceAddress[n].GetTag() == H225_AliasAddress::e_h323_ID)
+					H323SetAliasAddress(alias, Setup.m_sourceAddress[n]);
+	}
+
 	HandleH245Address(Setup);
 	HandleFastStart(Setup, true);
 	return true;
 }
 --
Option ScreenSourceAddressH323ID of [RoutedMode] section is added to signal 
gk to change H323_id of sourceAddress. I think it's simple also to modify 
dialedDigits field of sourceAddress to affect CallingPartyNumber. And, 
finally we may change number in UUIE something like this.

What do you think?

Regards.

On Wed, 28 Jan 2004 17:24:29 +0100, Zygmuntowicz Michal 
<m.z...@on...> wrote:

> As names for the Screen... options tell what IE are affected, you can see 
> that no User-User IE
> is screened. Maybe we should have an another option ScreenUUIE...
>
> ----- Original Message ----- From: "Rich" <dam...@ya...>
> Sent: Wednesday, January 28, 2004 2:27 PM
>
>
>> In gnugk 2.2 in routed mode, ScreenCallingPartyNumberIE and 
>> ScreenDisplayIE can be used to modify the calling number to a desired
> value in an admissionrequest.
>>
>> Unfortunately the UUIE field in the Q.931 PDU still contains the 
>> original calling number.
>>
>> Not sure whether this is by design or whether this has been overlooked.
>>
>> If the UUIE would also contain the modified number we would effectively 
>> have implemented a simple form of CLI hiding. Ideally it
> would also be possible to not just forward the entire UUIE that includes 
> information that we may not wish to show to the called
> party such as the information contained in the sourceInfo field.
>
>
>
> -------------------------------------------------------
> The SF.Net email is sponsored by EclipseCon 2004
> Premiere Conference on Open Tools Development and Integration
> See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
> http://www.eclipsecon.org/osdn
> _______________________________________________
> List: Ope...@li...
> Archive: http://sourceforge.net/mailarchive/forum.php?forum_id=3079
> Homepage: http://www.gnugk.org/
>
>



-- 
Using M2, Opera's revolutionary e-mail client: http://www.opera.com/m2/