[Openbts-discuss] 2.4 patches, second set

[Alexander C. <ale...@gm...>]

Hi all,

Here is a result of two more sleepless nights and valgrind checking.

* openbts-2.4-freeelement.diff
oSIP messages should be freed with its own function, not with delete.
This may cause crashes.

* openbts-2.4-mismatched-delete.diff
Just sanity patch - in all popular OSes delete and delete[] are equal,
but still it's a good idea to use them properly.

* openbts-2.4-sms-backport.diff
Just a few bugfies backported from 2.5 branch. Not sure are they really
have any good impact on 2.4, but no harm either.

* openbts-2.4-sms-crash.diff
Now! Real fix for SMS crash problem.
It's so simple, but took me looong time to get notice.

* openbts-2.4-srtncpy.diff
strncpy() does not put \0 at the end of a string if string size is equal
to buffer provided. So we should put it manually, or we'll get wrong
length with strlen() and possibly other bad ramifications.

* openbts-2.4-sms-fill-unused.diff
Fill unused bits in TLDeliver header with 0s as spec requires. This also
makes valgrind happy.

* openbts-2.4-sms-fill-unused-hack.diff
This makes valgrind even more happy, but I'm not sure this is a correct
fix. proably it just hides another bug - I think there should be no unfilled
8 bits at the end of the message.

-- 
Regards,
Alexander Chemeris.