Re: [Opalvoip-devel] Regression found in OPAL v3.14.1

[Robert J. <ro...@vo...>]

Actually can you try the following patch? If it works I will check it in.

Index: src/h323/h323caps.cxx
===================================================================
--- src/h323/h323caps.cxx    (revision 32247)
+++ src/h323/h323caps.cxx    (working copy)
@@ -2985,13 +2985,13 @@
          H323Capability * capability = 
allCapabilities.FindCapability(pdu.m_capabilityTable[i].m_capability);
          if (capability != NULL) {
            H323Capability * copy = (H323Capability *)capability->Clone();
+          OpalMediaFormatList::const_iterator it = 
localFormats.FindFormat(copy->GetMediaFormat());
+          if (it != localFormats.end())
+            copy->UpdateMediaFormat(*it);
            if (!copy->OnReceivedPDU(pdu.m_capabilityTable[i].m_capability))
              delete copy;
            else {
copy->SetCapabilityNumber(pdu.m_capabilityTable[i].m_capabilityTableEntryNumber);
-            OpalMediaFormatList::const_iterator it = 
localFormats.FindFormat(copy->GetMediaFormat());
-            if (it != localFormats.end())
-              copy->UpdateMediaFormat(*it);
              table.Append(copy);
            }
          }

*Robert Jongbloed*
/OPAL/OpenH323/PTLib Architect and Co-founder./
Commercial support at http://www.voxlucida.com.au

On 27/06/2014 9:05 PM, Harald Karner wrote:
> Hi,
>
> I've just upgraded OPAL from v3.14.0 to v3.14.1 and found a regression.
> I tracked it down to this commit:
>
> http://sourceforge.net/p/opalvoip/code/31700/
>
> It appears, contrary to what the commit message says ("...using local
> media options as base for remote H.323 capabilities..."), the remote
> options are rather overwritten by the local ones.
>
> In my case it looks like this: locally I have H.264 level 4.1, remote
> has H.264 level 2.2, but in OpalCall::SelectMediaFormats I get the
> remote formats as H.264 level 4.1, which is then used for OLC (and gets
> rejected from the remote side).
>
> Regards,
> Harald
>
>
> ------------------------------------------------------------------------------
> Open source business process management suite built on Java and Eclipse
> Turn processes into business applications with Bonita BPM Community Edition
> Quickly connect people, data, and systems into organized workflows
> Winner of BOSSIE, CODIE, OW2 and Gartner awards
> http://p.sf.net/sfu/Bonitasoft
> _______________________________________________
> Opalvoip-devel mailing list
> Opa...@li...
> https://lists.sourceforge.net/lists/listinfo/opalvoip-devel