Re: [Opalvoip-user] Incorrect Response returned in v3.10.5 for Do Not Disturb and Ignored calls

[Robert J. <ro...@vo...>]

Good find! I have checked in a fix.

Thank you very much for your efforts.

Robert Jongbloed
OPAL/OpenH323/PTLib Architect and Co-founder.


> -----Original Message-----
> From: Peetz David (ST-CO/ENG2.32) [mailto:Dav...@us...]
> Sent: Friday, 18 May 2012 1:19 AM
> To: opa...@li...
> Subject: [Opalvoip-user] Incorrect Response returned in v3.10.5 for Do
> Not Disturb and Ignored calls
> 
> After upgrading to Luyten v3.10.5, we discovered our application no
> longer returns a 486 "Busy Here" response when the user performs a Do
> Not Disturb or Ignore Call action with our application.   Instead, a
> 503 "Bad Gateway" response is being returned.  This functionality
> previously worked in Luyten v3.10.4.
> Our application is informing the OPAL library to return the 486
> Response via the reason parameter in OpalCall::Clear().
> 
> It appears the behavior change was introduced in SVN revision 27079
> where in OpalCall::Clear()
> 
>  PSafePtr<OpalConnection> connection;
>  while (EnumerateConnections(connection, PSafeReadWrite))
>    connection->Release(reason);
> 
> was replaced with
> 
>   switch (connectionsActive.GetSize()) {
>     case 0 :
>       break;
> 
>     case 1 :
>       connectionsActive.GetAt(0, PSafeReference)->Release();
>       break;
> 
>     default :
>       // Release all but A-Party, it gets done in the B-Party
> OnReleased thread.
>       for (PINDEX i = 1; i < connectionsActive.GetSize(); ++i)
>         connectionsActive.GetAt(i, PSafeReference)->Release();
> 
> Using the default reason parameter for Release() will cause
> SIP_PDU::StatusCodes GetStatusCodeFromReason() to never find a Call
> End Reason and by default, return SIP_PDU::Failure_BadGateway.
> Going back to the previous method of passing the reason parameter in
> the Release() function call (i.e. connectionsActive.GetAt(i,
> PSafeReference)->Release(reason); ) in OpalCall::Clear() seems to
> resolve this issue.
> 
> Is this bug "fix" warranted, or is our application not following the
> "best practice" for specifying call end reasons to OPAL?
> 
> Thanks,
> 
> David Peetz
> 
> 
> ----------------------------------------------------------------------
> --------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond.
> Discussions will include endpoint security, mobile security and the
> latest in malware threats.
> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Opalvoip-user mailing list
> Opa...@li...
> https://lists.sourceforge.net/lists/listinfo/opalvoip-user