[Oorexx-bugs] [ oorexx-Bugs-1758305 ] ooDialog - setting of modal flag in startIt is ambiguous

[SourceForge.net <no...@so...>]

Bugs item #1758305, was opened at 2007-07-21 23:14
Message generated for change (Settings changed) made by bigrixx
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=684730&aid=1758305&group_id=119701

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: External Functions
>Group: 3.2.0
Status: Pending
Resolution: Fixed
Priority: 2
Private: No
Submitted By: Mark Miesfeld (miesfeld)
Assigned to: Mark Miesfeld (miesfeld)
Summary: ooDialog - setting of modal flag in startIt is ambiguous

Initial Comment:
In the startIt methods of the DynamicDialog and ResDialog classes the setting of the modal flag is ambiguous.  The logic of the if statements allows the flag to be something other than 0 or 1.

Although, if one traces down all the places where startIt is called in the current code, it can be seen that this does not matter at this time.  But, you shouldn't have to back trace all the calls and if ooDialog is extended it would be best if the logic was explicit.

----------------------------------------------------------------------

Comment By: Mark Miesfeld (miesfeld)
Date: 2007-07-21 23:20

Message:
Logged In: YES 
user_id=191588
Originator: YES

Committed revision 614.

This commit fixed the logic so that the modal flag will always be set to
either 0 or 1.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=684730&aid=1758305&group_id=119701