Menu
▾
▴
[Oorexx-bugs] [ oorexx-Bugs-1761952 ] RFE 1754742 default methods need rework.
|
From: SourceForge.net <no...@so...> - 2007-07-27 12:06:48
|
Bugs item #1761952, was opened at 2007-07-27 08:00 Message generated for change (Comment added) made by bigrixx You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684730&aid=1761952&group_id=119701 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Classes Group: None >Status: Pending >Resolution: Fixed Priority: 5 Private: No Submitted By: Rick McGuire (bigrixx) >Assigned to: David Ashley (wdashley) Summary: RFE 1754742 default methods need rework. Initial Comment: The refactoring introduced by RFE 1754742 is really backwards. The supplier method should not be an abstract method. The abstract methods should be allIndexes and allItems. Defining allItems by using supplier allItems is a very badly performing implementation. This would force many extra items to get created for some very fundamental operations, rending these default implementations essentially useless. On top of that, any implementation would need to produce the equivalent of allItems and allIndexes results just to implementent a supplier method in the first place. ---------------------------------------------------------------------- >Comment By: Rick McGuire (bigrixx) Date: 2007-07-27 08:06 Message: Logged In: YES user_id=1125291 Originator: YES David, Some more doc changes introduced by this. On the Collection class, the allItems and allIndexes methods are now abstract. Add the index method as an abstract method. The supplier method is no longer abstract. ---------------------------------------------------------------------- Comment By: Rick McGuire (bigrixx) Date: 2007-07-27 08:02 Message: Logged In: YES user_id=1125291 Originator: YES Committed revision 637. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684730&aid=1761952&group_id=119701 |