[Oorexx-rfes] [ oorexx-Feature Requests-2842707 ] Fix and document return from DynamicDialog::create()

[SourceForge.net <no...@so...>]

Feature Requests item #2842707, was opened at 2009-08-22 12:02
Message generated for change (Settings changed) made by miesfeld
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=684733&aid=2842707&group_id=119701

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: ooDialog
>Group: ooDialog 4.2.0
>Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Mark Miesfeld (miesfeld)
Assigned to: Mark Miesfeld (miesfeld)
Summary: Fix and document return from DynamicDialog::create()

Initial Comment:
Currently the return from DynamicDialog::create() is not documented anywhere, except indirectly by this example:

rc = MyDialog~Create(20, 20, 300, 200, "My first Dialog", ,
"THICKFRAME NOMENU", , "Courier", 12, 100)
if rc <> 0 then MyDialog~Execute

Which implies that 0 is failure, not 0 is success.

Currently the code returns the pointer value of the in-memory dialog template.  This is somewhat silly, because the user can not possibly do anything with the pointer value, and the ooDialog code does not use it either.  Internally ooDialog uses the activePtr attribute.

The return should be .true for success and .false for failure, and documented that way.

----------------------------------------------------------------------

Comment By: Mark Miesfeld (miesfeld)
Date: 2009-08-22 12:25

Message:
Committed revision 5096.  Code
Committed revision 5097.  Documentation


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=684733&aid=2842707&group_id=119701