[Oorexx-bugs] [ oorexx-Patches-2972116 ] orxsql.cpp SQLDIAG and SQLRETURN not set

[SourceForge.net <no...@so...>]

Patches item #2972116, was opened at 2010-03-17 14:31
Message generated for change (Comment added) made by bwcherry
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=684732&aid=2972116&group_id=119701

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bug fix
Group: None
Status: Closed
Resolution: Invalid
Priority: 5
Private: No
Submitted By: Brandon Cherry (bwcherry)
Assigned to: David Ashley (wdashley)
Summary: orxsql.cpp SQLDIAG and SQLRETURN not set

Initial Comment:
SQLDIAG and SQLRETURN were not getting set appropriately

----------------------------------------------------------------------

>Comment By: Brandon Cherry (bwcherry)
Date: 2010-03-17 15:32

Message:
I'm not going to dispute that this is the most direct or elegant way to do
it, as I am still learning C++. What I will dispute is the fact that the
variables are not getting set. Have you actually tested it?

----------------------------------------------------------------------

Comment By: David Ashley (wdashley)
Date: 2010-03-17 15:27

Message:
This patch is really not the way to set these variables. The original code
actually does work as designed.

Both the dbconnx and sqlstatement class derrive from the cli class. The
cli class is where the SQLRETURN attribute is defined. Any reference to
this attribute will cause the instance storage to be accessed for the value
and this is the value set in the original code. The patch uses an extra
step to set this value by invoking the 'SQLRETURN=' method and thus is
redundant.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=684732&aid=2972116&group_id=119701