From: Rick M. <obj...@gm...> - 2009-03-01 21:30:01
|
Mark, All of the test suite is passing on 32-bits with the digits changes. I had to make a few updates to the tests for how 64-bits were handled since we can't rely on the digits() setting any more for a lot of the limits. There might be a few additional adjustments required if you could take a crack at running these in 64-bits. Rick On Sat, Feb 28, 2009 at 11:18 PM, Mark Miesfeld <mie...@gm...> wrote: > Hi Rick, > > The last commit breaks the build on 64-bit systems. I wasn't sure if > you were not done, or if it was an oversight. Plus, I'm not quite > sure what the correct thing should be. > > Lot of help I'm turning out to be. <grin> > > #include <limits.h> > > #ifdef __REXX64__ > const wholenumber_t Numerics::MAX_WHOLENUMBER = __INT64_C(999999999999999999); > const wholenumber_t Numerics::MIN_WHOLENUMBER = __INT64_C(-999999999999999999); > const wholenumber_t Numerics::MAX_EXPONENT = __INT64_C(999999999999999999); > const wholenumber_t Numerics::MIN_EXPONENT = __INT64_C(-999999999999999999); > // the digits setting used internally for function/method arguments to allow > // for the full range > const size_t Numerics::ARGUMENT_DIGITS = ((size_t)20); > > snip > > #endif > const wholenumber_t Numerics::MAX_EXPONENT = 999999999; > const wholenumber_t Numerics::MIN_EXPONENT = -999999999; > > > That ends up initializing MAX_EXPONENT and MIN_EXPONENT twice on a 64-bit build. > > I think the max and min exponent intializations need to be removed > from #ifdef __REXX64__ > > But, don't max and min whole number also to revert to just one > initialization (99999999 and -999999999) also? > > -- > Mark Miesfeld > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Oorexx-devel mailing list > Oor...@li... > https://lists.sourceforge.net/lists/listinfo/oorexx-devel > |