Menu
▾
▴
Re: [Oorexx-devel] AIX 64 bit patch
|
From: Rainer T. <ta...@ta...> - 2008-12-30 20:17:56
|
Hello, Rick McGuire wrote: > If rexxplatformdefs.h is the location for the Windows version of this, > then it's probably the most appropriate place for the *ix equivalent. > > sorry, I forgot to check the Windows version... The unix/rexxplatformdefs.h is good. I only have used the __REXX64__ to provide a __INT64_C suitable for 32 bit (even if currently not used). > Rick > Bye Rainer > On Tue, Dec 30, 2008 at 2:38 PM, Mark Miesfeld <mie...@gm...> wrote: > >> On Tue, Dec 30, 2008 at 11:15 AM, Rainer Tammer <ta...@ta...> wrote: >> >> >>> there is a little problem with the patch... >>> You have unfortunately used the 32 bit part (with the LL): >>> >>> #ifndef __INT64_C >>> >>> #define __INT64_C(c) c ## L <----- this is the 64 bit version >>> >> Sorry, I wasn't thinking. I'll change that. >> >> >>> I think the limitation to __REXX64__ is necessary as this version is only >>> for 64 bit. >>> >> I don't think it is necessary because the actual use of __INT64_C is >> already wrapped with ifdef __REXX64__. >> >> >>> If you like to add this to rexxplatformdefs.h then it is important that >>> rexxplatformdefs.h is >>> always included after rexxapitypes.h. >>> >> It is always included after rexxapitypes.h >> >> >>> I think rexxapitypes.h would be a >>> safer place. >>> >> Rick is the ultimate decider on where things should go. It wouldn't >> be the first time I put something in the wrong place. <grin> >> >> If he thinks it should be moved, then I will. I put it there because: >> 1.) It is not a type. 2.) Windows uses the same define but with LL >> because on Windows 64-bit a long is still 32-bits so long long is >> correct. That makes the define a sort of platform specific define. >> Which in turn seems to dictate it should go in rexxplatformdefs.h >> >> -- >> Mark Miesfeld >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> Oorexx-devel mailing list >> Oor...@li... >> https://lists.sourceforge.net/lists/listinfo/oorexx-devel >> >> > > ------------------------------------------------------------------------------ > _______________________________________________ > Oorexx-devel mailing list > Oor...@li... > https://lists.sourceforge.net/lists/listinfo/oorexx-devel > > > |