Re: [Ocaml-lib-devel] [PATCH] bitSet.ml/bitSet.mli: added diff, diff_sym, inter and union

[Janne H. <ja...@hy...>]

OK, renamed diff_sym to sym_diff and committed.

ciao,
janne

Bardur Arantsson wrote:
> On Tue, Dec 21, 2004 at 11:28:58PM +0200, Janne Hellsten wrote:
> 
> 
>>This patch adds new functionality to BitSet.  These functions were 
>>discussed earlier on this mailing lists.
>>
>>The patch does not modify old functions, just adds new ones.  A careful 
>>reader will note that it is doing a bit of extra work.. I doubt it will 
>>make much of a difference, but perhaps I can optimize these later on.
>>
>>It has been tested with the testing suite.
>>
>>If the diff is OK, I can commit to CVS myself (testers included).
> 
> 
> Just a tiny naming nit: diff_sym should probably be called
> sym_diff since that more closely resembles the full name,
> "symmetric difference".
> 
> The code looks fine to me.
>