From: Richard J. <ri...@an...> - 2008-05-19 09:43:42
|
On Sun, May 18, 2008 at 11:28:08PM +0300, Janne Hellsten wrote: > What kind of example uses did you have in mind for the Option additions? > > Not sure if I agree that get_exn is too useful an addition. I disagree: I think that as long as additional functions maintain a consistent style with the rest of the library, are working, documented and useful to someone, and don't consume any more "module namespace", then there shouldn't be any barrier to adding them. In this case I have no problem with David's additional functions, the patches are fine[1], and I would be inclined to add them. Rich. [1] David: please always post unified diffs as in your second email, not tarballs as in the first. -- Richard Jones Red Hat |