[NSIS-Bugs] [ nsis-Bugs-659387 ] Banner.dll and MUI's 111

[SourceForge.net <no...@so...>]

Bugs item #659387, was opened at 2002-12-28 16:29
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373085&aid=659387&group_id=22049

Category: Plugin
Group: 2.0 Beta Series
>Status: Closed
>Resolution: Fixed
Priority: 3
Submitted By: Denis Shvedchenko (dshvedchenko)
Assigned to: Amir Szekely (kichik)
Summary: Banner.dll and MUI's 111

Initial Comment:
files:
Contrib\UIs\
 modern.exe modern2.exe modern3,exe
have hardcoded string in banner dialog:
Please wait while Setup is loading...


----------------------------------------------------------------------

>Comment By: Amir Szekely (kichik)
Date: 2003-01-27 17:50

Message:
Logged In: YES 
user_id=584402

Fixed in latest CVS version. See Banner's readme for more 
information.

----------------------------------------------------------------------

Comment By: Amir Szekely (kichik)
Date: 2002-12-28 18:07

Message:
Logged In: YES 
user_id=584402

Yea, you are right, I thought you meant something else... I 
thought you meant the verifying text NSIS shows, and that's 
in lang.cpp not in default.exe. I will add an option to change 
this text for banner in the next version.

----------------------------------------------------------------------

Comment By: Denis Shvedchenko (dshvedchenko)
Date: 2002-12-28 17:33

Message:
Logged In: YES 
user_id=676154

No there is no hardcoded string in  111 dialog of default.exe.
I'm talking about using Banner::show and using modern2.exe

here is resource hacker's extract of modern2.exe

111 DIALOGEX 0, 0, 167, 42
STYLE DS_FIXEDSYS | DS_MODALFRAME | DS_CENTER | 
WS_POPUP | WS_VISIBLE
CAPTION ""
LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
FONT 8, "MS Shell Dlg"
{
   CONTROL "", 1030, STATIC, SS_CENTER | WS_CHILD | 
WS_VISIBLE | WS_GROUP, 40, 25, 120, 10 
   CONTROL 103, -1, STATIC, SS_ICON | WS_CHILD | 
WS_VISIBLE, 10, 10, 21, 20 
   CONTROL "Please wait while Setup is loading...", -1, 
STATIC, SS_CENTER | WS_CHILD | WS_VISIBLE | 
WS_GROUP, 40, 10, 120, 10 
}



----------------------------------------------------------------------

Comment By: Amir Szekely (kichik)
Date: 2002-12-28 16:51

Message:
Logged In: YES 
user_id=584402

PS it is not only hardcoded in the MUI but in the normal UI 
too (see default.exe).

----------------------------------------------------------------------

Comment By: Amir Szekely (kichik)
Date: 2002-12-28 16:50

Message:
Logged In: YES 
user_id=584402

I asumme you are talking about the fact that it is 
unchangable using language files or language strings, you 
are right. This is because when this dialog shows up you the 
installer data is still not verified and uncompressed. If NSIS 
will wait for the installer data to be verified and uncompress 
and only then show this dialog, the dialog will be useless.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373085&aid=659387&group_id=22049