[NSIS-Bugs] [ nsis-Bugs-3092765 ] Silent installation into wrong target directory

[SourceForge.net <no...@so...>]

Bugs item #3092765, was opened at 2010-10-22 09:29
Message generated for change (Comment added) made by anders_k
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373085&aid=3092765&group_id=22049

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Michael Hopf (mhopf)
Assigned to: Nobody/Anonymous (nobody)
Summary: Silent installation into wrong target directory

Initial Comment:
Incorrect silent installation on Windows 2008 Enterprise:

Command: apache-tomcat-6.0.26.exe /S /D=c:\tomcat

Tomcat files are copied to "c:\Program Files" instead of "c:\tomcat"
The installation works fine on Windows XP and Windows 2003 Server systems.

Following response from apache/tomcat team: ASF Bugzilla – Bug 50140

----------------------------------------------------------------------

>Comment By: Anders (anders_k)
Date: 2010-10-22 22:37

Message:
http://svn.apache.org/repos/asf/tomcat/trunk/res/tomcat.nsi (I assume this
is the install script we are talking about) contains 

Function .onInit
  ;Reset install dir for 64-bit
  ExpandEnvStrings $0 "%PROGRAMW6432%"
  StrCmp $0 "%PROGRAMW6432%" +2 0
  StrCpy $INSTDIR "$0\Apache Software Foundation\Tomcat
@VERSION_MAJOR_MINOR@"

And your bug report talks about x64
(https://issues.apache.org/bugzilla/show_bug.cgi?id=50140) so I'm guessing
this is the issue.

I would suggest that you remove the InstallDir "$PROGRAMFILES\Apache
Software Foundation\Tomcat @VERSION_MAJOR_MINOR@" line and replace the
.onInit code with something like:

!include x64.nsh
Function .onInit
StrCmp "" $INSTDIR 0 skipinitinstdir
StrCpy $0 $ProgramFiles
${IfThen} ${RunningX64} ${|} StrCpy $0 $PROGRAMFILES64 ${|}
StrCpy $INSTDIR "$0\Apache Software Foundation\Tomcat
@VERSION_MAJOR_MINOR@"
skipinitinstdir:
....

Either way, /D= just sets $instdir before any script code is called,
anything after that is up to the script


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=373085&aid=3092765&group_id=22049