Re: [namedgraphs] SQL escaping bug found (and fixed)

['Asheesh L. <ng...@as...>]

On Thu, 16 Sep 2010, Jennifer Cormier wrote:

> This patch has been applied to the NG4J source code.
>
> Asheesh did some testing with MySQL and Apache Derby; I inspected the code
> and ran the NG4J tests with HSQLDB (in-memory), Apache Derby, PostgreSQL,
> and Oracle Express.
>
> For HSQLDB there were no failures/errors.
>
> For Apache Derby and PostgreSQL, there was a failure/error which was fixed
> by the patch, so with the patch no problems.
>
> For Oracle there were almost identical failures/errors both without and
> with the patch.  So that needs to be fixed.  It appears that after one of
> the failure/errors, the tables are deleted which causes the remaining
> tests to fail.  In running other tests which execute the NG4J database
> code, there were "maximum open cursors exceeded" type errors, probably due
> to ResultSet's not all being closed.

Oh, boy. Those should get fixed. They probably explain the memory 
leak-type errors we are seeing.

> Anyone have an opinion about using com.sun.rowset.CachedRowSet so that 
> ResultSet's can be closed, or other suggestions for the memory leak 
> issue identified by Graeme Stevenson?

I'll check out the latest CVS...

-- Asheesh.