Re: [Netatalk-devel] [olh@suse.de: [PATCH] fix some 2.0.2 compiler warnings] (fwd)

[didier <dga...@ma...>]

Andrew Morgan wrote:
> 
> Forwarding this on Olaf's behalf...
> 
>     Andy
> 
> 
Patch applied.
> suse.de ended up in the spamcop servers, so I cant post. Maybe you can
> have a look at it and forward it to the list.
> 
> ----- Forwarded message from Olaf Hering <ol...@su...> -----
> 
> Date: Tue, 25 Jan 2005 22:37:23 +0100
> Subject: [PATCH] fix some 2.0.2 compiler warnings
> From: Olaf Hering <ol...@su...>
> To: net...@li...
> 
> 
> auth.c:447: warning: `token' might be used uninitialized in this function
> relies on tklen==0
fixed
> 
> 
> mangle.c:30: warning: `mfilenamelen' might be used uninitialized in this 
> function
> might be true
Need work.
> 
> nfsquota.c:66: warning: passing arg of `callaurpc' discards qualifiers 
> from pointer target type
> quota.c:559: warning: passing arg of `getquota' discards qualifiers from 
> pointer target type
> needs checking
Fixed
> 
> afp_config.c:538: warning: `config' might be used uninitialized in this 
> function
> AFPConfigInit() can return NULL
It's ok.
> 
> catsearch.c:401: warning: large integer implicitly truncated to unsigned 
> type
> FINDERINFO_INVISIBLE is 0x4000 and htons makes attrs 0
> 
Need work.

> 
> /usr/src/packages/BUILD/netatalk-2.0.2/etc/afpd/file.c:2149: warning: 
> the use of `mktemp' is dangerous, better use `mkstemp'
No, we need a filename not a file descriptor.

> 
> main.c:85: warning: `ret' might be used uninitialized in this function
> possible if .op is unknown
Fixed

> 
> main.c:1207: warning: `sigsetmask' is deprecated (declared at 
> /usr/include/signal.h:184)
> main.c:1224: warning: `sigsetmask' is deprecated (declared at 
> /usr/include/signal.h:184)
> #ifdef __USE_BSD
> /* None of the following functions should be used anymore.  They are here
>    only for compatibility.  A single word (`int') is not guaranteed to be
>    enough to hold a complete signal mask and therefore these functions
>    simply do not work in many situations.  Use `sigprocmask' instead.  */
> 
Fixed but atalkd need a  lot of work, it does too much things in signal 
handlers.

> 
> config.c:331: warning: `cc' might be used uninitialized in this function
> if someone can run please Lindent over that file, I may even understand 
> readconf()
> 
> 

Didier