Menu
▾
▴
#522 netatalk 2.2.5 ACL wrapper code fails to build on OpenBSD
The netatalk 2.2.5 release seems to have added some wrapper functions into libatalk/util/unix.c but part of that code deals with ACLs and the fallback wrapper code for that fails to build on OpenBSD. There was a fix for include/atalk/acl.h already on the master branch and I see already included with 3.0.
Please back port this to the 2.2 branch.
http://sourceforge.net/p/netatalk/code/ci/3bff0d45274b4d8b79501729e3511e306981d628/
Getting libatalk/util/unix.c to compile is also an issue for me on Ubuntu Server 12.04 LTS and Raspbian, so I assume any Debian. It was not an issue in 2.2.4; it is new in 2.2.5. Using "./configure --enable-debian", and then "make", I get:
/bin/bash ../../libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../../sys -I../../include -D_U_="attribute((unused))" -g -O2 -I../../sys -MT unix.lo -MD -MP -MF .deps/unix.Tpo -c -o unix.lo unix.c
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../../sys -I../../include "-D_U_=attribute((unused))" -g -O2 -I../../sys -MT unix.lo -MD -MP -MF .deps/unix.Tpo -c unix.c -fPIC -DPIC -o .libs/unix.o
unix.c: In function 'ochmod':
unix.c:220:33: error: expected expression before ')' token
unix.c: In function 'daemonize':
unix.c:85:14: warning: ignoring return value of 'chdir', declared with attribute warn_unused_result [-Wunused-result]
unix.c:90:12: warning: ignoring return value of 'dup', declared with attribute warn_unused_result [-Wunused-result]
unix.c:91:12: warning: ignoring return value of 'dup', declared with attribute warn_unused_result [-Wunused-result]
make[3]: [unix.lo] Error 1
make[3]: Leaving directory
/home/user1/netatalk-2.2.5/libatalk/util' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory/home/user1/netatalk-2.2.5/libatalk'make[1]: [all-recursive] Error 1
make[1]: Leaving directory `/home/user1/netatalk-2.2.5'
make: *** [all] Error 2
[5bc621a52bd0986363accae36ad7f6ca3e4175dd]
Related
Commit: <Commit _id='5bc621a52bd0986363accae36ad7f6ca3e4175dd' tree_id='28e92d793db68b7e8ce9ce401a6f4f8673c6910b' committed=I{'date': datetime.datetime(2013, 7, 23, 12, 4, 58), 'email': 'sloowfranklin@gmail.com', 'name': 'Ralph Boehme'} authored=I{'date': datetime.datetime(2013, 7, 23, 12, 4, 58), 'email': 'sloowfranklin@gmail.com', 'name': 'Ralph Boehme'} message='Fixes for platforms without at funcs and without ACL support\n' parent_ids=I['8494416a71361aa160e29000200d8894f37cfe18'] child_ids=I['322ac21f3f8e17e33d8574157977347b672cb7e2'] repo_ids=I[ObjectId('503b705bfd48f843173d5fd3'), ObjectId('5910acbc2cd81052b64b3380'), ObjectId('5e503de0dd85f4654ba114ee'), ObjectId('5e828a7a9d8bdd372301c28f')]>