SourceForge has been redesigned. Learn more.
Close

#522 netatalk 2.2.5 ACL wrapper code fails to build on OpenBSD

open
nobody
None
1
2013-10-28
2013-08-23
Brad Smith
No

The netatalk 2.2.5 release seems to have added some wrapper functions into libatalk/util/unix.c but part of that code deals with ACLs and the fallback wrapper code for that fails to build on OpenBSD. There was a fix for include/atalk/acl.h already on the master branch and I see already included with 3.0.

Please back port this to the 2.2 branch.

http://sourceforge.net/p/netatalk/code/ci/3bff0d45274b4d8b79501729e3511e306981d628/

Discussion

  • Ivan X

    Ivan X - 2013-10-27

    Getting libatalk/util/unix.c to compile is also an issue for me on Ubuntu Server 12.04 LTS and Raspbian, so I assume any Debian. It was not an issue in 2.2.4; it is new in 2.2.5. Using "./configure --enable-debian", and then "make", I get:

    /bin/bash ../../libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../../sys -I../../include -D_U_="attribute((unused))" -g -O2 -I../../sys -MT unix.lo -MD -MP -MF .deps/unix.Tpo -c -o unix.lo unix.c
    libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../../sys -I../../include "-D_U_=attribute((unused))" -g -O2 -I../../sys -MT unix.lo -MD -MP -MF .deps/unix.Tpo -c unix.c -fPIC -DPIC -o .libs/unix.o
    unix.c: In function 'ochmod':
    unix.c:220:33: error: expected expression before ')' token
    unix.c: In function 'daemonize':
    unix.c:85:14: warning: ignoring return value of 'chdir', declared with attribute warn_unused_result [-Wunused-result]
    unix.c:90:12: warning: ignoring return value of 'dup', declared with attribute warn_unused_result [-Wunused-result]
    unix.c:91:12: warning: ignoring return value of 'dup', declared with attribute warn_unused_result [-Wunused-result]
    make[3]: [unix.lo] Error 1
    make[3]: Leaving directory /home/user1/netatalk-2.2.5/libatalk/util' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory/home/user1/netatalk-2.2.5/libatalk'
    make[1]:
    [all-recursive] Error 1
    make[1]: Leaving directory `/home/user1/netatalk-2.2.5'
    make: *** [all] Error 2

     

Log in to post a comment.