[Net-snmp-patches] [ net-snmp-Patches-1737727 ] Remove unused define NOACCESS in snmp_impl.h

[SourceForge.net <no...@so...>]

Patches item #1737727, was opened at 2007-06-15 11:45
Message generated for change (Comment added) made by tanders
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312694&aid=1737727&group_id=12694

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: joyceanmachine (joyceanmachine)
Assigned to: Nobody/Anonymous (nobody)
Summary: Remove unused define NOACCESS in snmp_impl.h

Initial Comment:
snmp_impl.h sets a define NOACCESS which is used nowhere else in the project. 

In parse.c there is _another_ define of NOACCESS which _is_ used. However, here it is explicitly checked if it was defined and explicitly redefined if it was set.

The NOACCESS in snmp_impl.h clashes with sys/vmuser.h on certain (probably all) AIX systems.

These seem like two good reasons to remove the define in snmp_impl.h

Attached patch does this. The patch works on most 5.3 and 5.4 versions (at least on all that I tried).

Would be good if this could be merged. Maybe even backmerged to 5.3 if it's not too much of an effort.

Cheers,
Thijs

----------------------------------------------------------------------

>Comment By: Thomas Anders (tanders)
Date: 2007-06-19 13:24

Message:
Logged In: YES 
user_id=848638
Originator: NO

I'd be fine with renaming/prefixing it for future releases. I also think
I've seen/discussed(?) this before, but can't say for sure (nor remember
where/when). Oh well.

----------------------------------------------------------------------

Comment By: joyceanmachine (joyceanmachine)
Date: 2007-06-19 12:50

Message:
Logged In: YES 
user_id=1682471
Originator: YES

Ah, hadn't thought of that. Yes, so backmerge might not be the best idea.

Alternative to this patch would be to rename the define. This would also
avoid confusion with the other NOACCESS define in parse.c.

But let's hear what the other developers have to say on this.



----------------------------------------------------------------------

Comment By: Wes Hardaker (hardaker)
Date: 2007-06-18 23:02

Message:
Logged In: YES 
user_id=76242
Originator: NO

erg.  looks simple, but is actually problematic.

NOACCESS can, in theory, be used in old-style MIB code to register a
column with no access to it.  I doubt this is actually used out in the
field (it's not used in our code base, as you noticed).  But in theory we
could actually break some other 3rd-party plugin that had used it in their
old-style code.

thoughts from other developers appreciated.

I'm leaning toward removing it I guess...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312694&aid=1737727&group_id=12694