From: SourceForge.net <no...@so...> - 2008-07-23 13:48:31
|
Patches item #1823800, was opened at 2007-11-01 02:38 Message generated for change (Comment added) made by jsafranek You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312694&aid=1823800&group_id=12694 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Praseed (praseedgopal) Assigned to: Magnus Fromreide (magfr) Summary: Kill -HUP <pid> doesn't reload trap2sink from snmpd.conf Initial Comment: Net-snmp release affected 5.4. I don't know about other releases. snmpd.conf man page says, The Net-SNMP agent can be instructed to re-read the various configuration files by sending a kill -HUP signal to the agent process. This is not working well for trap2sink directive in snmpd.conf, because of old sinks not been flushed. The given patch will register the releaser for the sink. --- agent/agent_read_config.c 2007-10-31 18:04:36.000000000 -0700 +++ agent/agent_read_config.c 2007-10-18 11:08:37.000000000 -0700 @@ -224,12 +224,10 @@ #endif #ifndef NETSNMP_DISABLE_SNMPV2C register_app_config_handler("trap2sink", - snmpd_parse_config_trap2sink, - snmpd_free_trapsinks, + snmpd_parse_config_trap2sink, NULL, "host [community] [port]"); register_app_config_handler("informsink", - snmpd_parse_config_informsink, - snmpd_free_trapsinks, + snmpd_parse_config_informsink, NULL, "host [community] [port]"); #endif register_app_config_handler("trapsess", ---------------------------------------------------------------------- >Comment By: Jan Safranek (jsafranek) Date: 2008-07-23 15:48 Message: Logged In: YES user_id=1784238 Originator: NO I think the patch is basically correct, if an user disables SNMPv1, the traps won't get cleared on SIGHUP. IMHO the snmpd_free_trapsinks callback should be added it to all trap-related handler registrations, it won't harm if it's called multiple times. ---------------------------------------------------------------------- Comment By: Magnus Fromreide (magfr) Date: 2008-01-12 12:20 Message: Logged In: YES user_id=1124910 Originator: NO I would like to know if you had disabled SNMPv1 in your build. When looking at the code it seems as if that might be the case. If that is so the the patch would only lessen the problem and not fix it completely so please tell if that is the case. It would also be interesting to know if adding SNMPv1 to the build works around the problem. All this said I am in favour of this patch. (Please note that the patch is reversed) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312694&aid=1823800&group_id=12694 |