Menu

#131 primitive folding patch second try

development
open
nobody
Program (79)
5
2005-04-06
2005-04-06
No

This patch replaces patch 1177007, which should now be
deleted.

This patch is an attempt to implement folding in the
nedit text buffer.

The code change was made against the V5.4 release, ie,
prior to the introduction of tabs.

Text is folded by calling a new macro function:

rangeset_set_folded(r,1)

..which marks a rangeset as folded

From Michael Smith
smithm@netapps.com.au

Discussion

  • Michael Smith

    Michael Smith - 2005-04-06

    Patch extracted from cvs with cvs diff

     
  • Uwe Lehnert

    Uwe Lehnert - 2005-04-11

    Logged In: YES
    user_id=794103

    First feedback after a quick implementation within nedit 5.4:

    Looks like the attached patch is not complete. At least
    the code inside "macro.c" for the new built-in macro subroutine
    "rangeset_set_folded(r,1)" is missing.

    After setting up this one by myself, i recognized, that text is
    only folded, if the line start is included within a rangeset
    with
    "is_folded" attribute set. The "fold" will become visible not
    after "rangeset_set_folded(r,1)" is being called but only if the
    text is being scrolled up or down (i'm not sure if this was your
    intention).

    There is also some code introduced within
    "RangesetSetFoldedState" which is "commented out".

    Do you have maybe forgotten some parts within the patch
    accidentally ?

     

Log in to post a comment.