#110 Forbid deletion of the "Plain" Text Drawing Style

development
closed-accepted
Eddy De Greef
Program (79)
5
2004-06-10
2004-06-10
Tony Balinski
No

Without this patch, you can easily delete all occurrences
of the "Plain" style. This breaks things. The patch allows
you to have more than one "Plain" style (as before), but
will not allow you to delete them all: one at least must
remain.

Discussion

  • Tony Balinski
    Tony Balinski
    2004-06-10

     
    Attachments
  • Eddy De Greef
    Eddy De Greef
    2004-06-10

    • labels: --> Program
    • milestone: --> development
    • assigned_to: nobody --> edg
     
  • Eddy De Greef
    Eddy De Greef
    2004-06-10

    Logged In: YES
    user_id=73597

    I consider this a bug fix, so I'd commit it right away, but
    I have two remarks:
    - Why did you remove the comment in macro.c? I see nothing
    wrong with it.
    - You renamed the "top" pattern to "", so why not remove
    the special case for "top" in macro.c too?

     
  • Tony Balinski
    Tony Balinski
    2004-06-10

    Logged In: YES
    user_id=618141

    Committing this is probably a good idea.
    The patch is quite old, and I have kept it up to date by
    regenerating it from time to time.
    Re - the comment: that's a mistake, I can't remember why I
    removed it.
    Re - access to "top" in macro.c: that is also a mistake,
    introduced no doubt by my patch updating! I did actually
    remove the "top" stuff in fillPatternResult(), leaving only the
    "else" limb of the test in which it occurs. If you do the check-
    in, I think you could make this change too.

     
  • Eddy De Greef
    Eddy De Greef
    2004-06-10

    Logged In: YES
    user_id=73597

    It's in CVS (with the additional changes). Thanks.

     
  • Eddy De Greef
    Eddy De Greef
    2004-06-10

    • status: open --> closed-accepted