Without this patch, you can easily delete all occurrences
of the "Plain" style. This breaks things. The patch allows
you to have more than one "Plain" style (as before), but
will not allow you to delete them all: one at least must
remain.
I consider this a bug fix, so I'd commit it right away, but
I have two remarks:
- Why did you remove the comment in macro.c? I see nothing
wrong with it.
- You renamed the "top" pattern to "", so why not remove
the special case for "top" in macro.c too?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Committing this is probably a good idea.
The patch is quite old, and I have kept it up to date by
regenerating it from time to time.
Re - the comment: that's a mistake, I can't remember why I
removed it.
Re - access to "top" in macro.c: that is also a mistake,
introduced no doubt by my patch updating! I did actually
remove the "top" stuff in fillPatternResult(), leaving only the
"else" limb of the test in which it occurs. If you do the check-
in, I think you could make this change too.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Logged In: YES
user_id=73597
I consider this a bug fix, so I'd commit it right away, but
I have two remarks:
- Why did you remove the comment in macro.c? I see nothing
wrong with it.
- You renamed the "top" pattern to "", so why not remove
the special case for "top" in macro.c too?
Logged In: YES
user_id=618141
Committing this is probably a good idea.
The patch is quite old, and I have kept it up to date by
regenerating it from time to time.
Re - the comment: that's a mistake, I can't remember why I
removed it.
Re - access to "top" in macro.c: that is also a mistake,
introduced no doubt by my patch updating! I did actually
remove the "top" stuff in fillPatternResult(), leaving only the
"else" limb of the test in which it occurs. If you do the check-
in, I think you could make this change too.
Logged In: YES
user_id=73597
It's in CVS (with the additional changes). Thanks.