#337 Glitch in Ada syntax highlighting

release
closed-fixed
None
2
2005-11-28
2003-12-12
No

In the Ada syntax highlighting pattern, if the with'ed
or use'd package has a single letter then it isn't
caught by the pattern.

Example

with Ada.Strings.Unbounded
with C.Strings

(works OK, but)

with Interfaces.C.Strings
use Interfaces.C

(neither works because of the single "C")

I'll see if I can parse the regexps well enough to fix
this myself.

Discussion

  • Thorsten Haude
    Thorsten Haude
    2004-07-14

    Logged In: YES
    user_id=119143

    Could you come up with a short example where this can be
    seen? I don't know Ada and neither do I see a difference
    between the two cases.

     
  • Thorsten Haude
    Thorsten Haude
    2005-02-06

    Logged In: YES
    user_id=119143

    I can see the C here as highlightted. What effect do you
    expect? What effect do you get?

     
  • Logged In: YES
    user_id=612097

    Now I see what's wrong. I forgot the semicolons at the end
    in the examples. Compare
    ...

    with Interfaces.C.Strings;
    use Interfaces.C;

    ...
    with the text
    ...

    with Ada.Strings.Unbounded;
    with C.Strings;

    ...
    and you'll see what I mean. They are both package
    inclusions, should be highlighted identically.

    The bug is in the "withs use" subpattern, but I'm not so
    good with regexps, I didn't manage to fix it :-(

    If you don't see it I can upload a screenshot.

     
  • Thorsten Haude
    Thorsten Haude
    2005-02-07

    • priority: 5 --> 2
    • assigned_to: nobody --> yooden
     
  • Thorsten Haude
    Thorsten Haude
    2005-02-07

     
    Attachments
  • Thorsten Haude
    Thorsten Haude
    2005-02-07

    Logged In: YES
    user_id=119143

    I attached a possible fix for this. I still don't know Ada,
    so please check this pattern in situation where it might break.

    A short description how to handle the pattern file is in the
    pattern file. Let me know if any problem comes up.

     
  • Thorsten Haude
    Thorsten Haude
    2005-11-28

    • milestone: --> release
    • status: open --> open-fixed
     
  • Thorsten Haude
    Thorsten Haude
    2005-11-28

    Logged In: YES
    user_id=119143

    No response, so it seems to be fixed. The bug is left open
    until the new pattern set is brought into CVS.

     
  • Thorsten Haude
    Thorsten Haude
    2005-11-28

    • status: open-fixed --> closed-fixed