Re: [Nasm-devel] [Nasm-bugs] [ nasm-Feature Requests-3370684 ] Make insns.dat more readable (fix attached)

[Cyrill G. <gor...@gm...>]

On Wed, Jul 20, 2011 at 01:50:03PM -0700, H. Peter Anvin wrote:
> On 07/20/2011 12:19 PM, anonymous coward wrote:
> >>>> You can verify that the new insns.dat and insns.pl produce
> >>>> byte-identical output to the old insns.dat and insns.pl [...]
> >>> if the output is identical, I don't see any reason *not* to merge it
> >> I merged the patch.
> > 
> > The commit only shows insns.dat and insns.pl but no
> > testcases -- did that old-vs-new testing happen at all?
> > 
> > Would sync'ing a tree to before and after this change,
> > and then diff'ing the 5 generated insns?.? files suffice?
> > 
> 
> Yes, that would suffice.  It would be sufficient (but not necessary) to
> prove that nothing changed.
> 
> 	-hpa
> 

I somehow missed this thread ;)

Just to clarify -- before commit the change I did compare
insns*.c files generated before and after the commit to check
that instructions remains the same, and they do, so it's
1:1 mapping.

	Cyrill