From: Cyrill G. <gor...@op...> - 2009-05-15 06:11:39
|
On 5/15/09, Cyrill Gorcunov <gor...@op...> wrote: > On 5/15/09, Cyrill Gorcunov <gor...@op...> wrote: >> On 5/15/09, H. Peter Anvin <hp...@zy...> wrote: >>> Cyrill Gorcunov wrote: >>>> +; >>>> +; FIXME: spec error /r is needed >>>> +VPROTD xmmreg,xmmrm,imm [rmi: xop.m8.w0.l0.p0 c2 /r ib] AMD,SSE5,SO >>>> +VPROTQ xmmreg,xmmrm,xmmreg [rmv: xop.m9.w0.nds.l0.p0 93 >>>> /r] AMD,SSE5,SO >>>> +VPROTQ xmmreg,xmmreg,xmmrm [rmv: xop.m9.w1.nds.l0.p0 93 >>>> /r] AMD,SSE5,SO >>>> +; >>> >>> The last one should presumably be rmv:? >>> >>> Other than that, it looks good to me; before I commit it, though, I >>> wanted to double-check with you -- we're trying to get NASM licensed >>> under the 2-BSD license and are only waiting for a few remaining >>> contributors to OK the change; are you willing to contribute your >>> changes under both the LGPL and 2-BSD licenses? >>> >>> -hpa >>> >>> -- >>> H. Peter Anvin, Intel Open Source Technology Center >>> I work for Intel. I don't speak on their behalf. >>> >>> >> Thanks Peter will fix, was a misprint! I'm fine with 2-BSD license as >> well. >> > To be precise in words - i'm ok with botu licenses > Btw, Peter, there was v2 of these patches sent. So please check that you're committing v2. |