Re: [Nasm-devel] bug??? 2.01*

[H. P. A. <hp...@zy...>]

Frank Kotler wrote:
> Ismail Dönmez wrote:
> 
> ...
>>     error(ERR_FATAL, "unable to open include file `%s'", file);
> 
> Yes. I suppose we're not expected to return from that (according to the 
> comments), but we do(!). We appear to be returning "true" from 
> "is_suppressesed_warning". Blindly flailing at it, I find that:
> 
> --- ../nasmgit/nasm.c	2008-01-21 05:46:26.000000000 -0500
> +++ nasm.c	2008-01-21 17:42:09.000000000 -0500
> @@ -1624,7 +1624,7 @@
>            * See if it's a pass-one only warning and we're not in pass
>   	 * zero or one.
>            */
> -        ((severity & ERR_PASS1) && pass0 != 1);
> +        ((severity & ERR_PASS1) && pass0 > 1);
>   }
> 
>   /**
> 
> Fixes my immediate problem ("problem" only if I give an incorrect 
> command line). Lord knows what it breaks. Any ideas what it's *supposed* 
> to be?
> 

Well, we sure as HELL shouldn't be returning true from 
is_suppressed_warning() if it ISN'T A BLOODY WARNING...

	-hpa